refactor: remove deprecated format field from ExcelProperty and add comprehensive tests for date formatting #610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omprehensive tests for date formatting
psxjoy
requested changes
Sep 27, 2025
fesod/src/test/java/org/apache/fesod/excel/annotation/ExcelPropertyFormatTest.java
Outdated
Show resolved
Hide resolved
fesod/src/test/java/org/apache/fesod/excel/annotation/ExcelPropertyFormatTest.java
Outdated
Show resolved
Hide resolved
…for clarity and consistency
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request removes the deprecated format field from the ExcelProperty annotation and adds comprehensive tests for date formatting functionality using the @DateTimeFormat annotation.
- Removal of deprecated
formatfield fromExcelPropertyannotation - Addition of comprehensive test coverage for date formatting scenarios
- Tests cover various date patterns including Chinese characters, multiple formats, null handling, and read/write operations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ExcelProperty.java | Removes deprecated format field and its import dependency |
| ExcelPropertyFormatTest.java | Adds comprehensive test suite for date formatting with various scenarios and edge cases |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
fesod/src/test/java/org/apache/fesod/excel/annotation/ExcelPropertyFormatTest.java
Outdated
Show resolved
Hide resolved
fesod/src/test/java/org/apache/fesod/excel/annotation/ExcelPropertyFormatTest.java
Outdated
Show resolved
Hide resolved
alaahong
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…omprehensive tests for date formatting
Purpose of the pull request
Closed: #473
What's changed?
Checklist